Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilterProcessor: Fix predicate assembling for EXISTS and NOT EXISTS operators #87

Merged
merged 3 commits into from
Jun 25, 2024
Merged

FilterProcessor: Fix predicate assembling for EXISTS and NOT EXISTS operators #87

merged 3 commits into from
Jun 25, 2024

Conversation

raviks789
Copy link
Contributor

fix #86

@raviks789 raviks789 requested review from nilmerg and yhabteab June 19, 2024 12:46
@cla-bot cla-bot bot added the cla/signed label Jun 19, 2024
@raviks789 raviks789 force-pushed the fix/filter-processor-empty-column branch from 0c5dbda to b975e10 Compare June 19, 2024 12:47
@raviks789 raviks789 self-assigned this Jun 19, 2024
@nilmerg
Copy link
Member

nilmerg commented Jun 24, 2024

Please show a stacktrace.

@raviks789
Copy link
Contributor Author

raviks789 commented Jun 24, 2024 •
edited
Loading

Please show a stacktrace.

Check the below screenshot.

Screenshot 2024-06-24 at 10 46 48

nilmerg
nilmerg requested changes Jun 24, 2024
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case for this.

@yhabteab yhabteab removed their request for review June 24, 2024 11:08
@raviks789 raviks789 force-pushed the fix/filter-processor-empty-column branch from ba1fcc4 to 6550027 Compare June 24, 2024 13:17
@raviks789 raviks789 requested a review from nilmerg June 24, 2024 13:17
@raviks789 raviks789 force-pushed the fix/filter-processor-empty-column branch from 6550027 to 8226067 Compare June 24, 2024 13:19
@raviks789 raviks789 force-pushed the fix/filter-processor-empty-column branch from 8226067 to 23e3e9d Compare June 24, 2024 13:20
@nilmerg nilmerg added this to the 0.7.1 milestone Jun 25, 2024
@nilmerg nilmerg added the bug Something isn't working label Jun 25, 2024
@nilmerg nilmerg merged commit e80f1b7 into main Jun 25, 2024
13 checks passed
@nilmerg nilmerg deleted the fix/filter-processor-empty-column branch June 25, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

Assignees

@raviks789 raviks789

Labels
bug Something isn't working cla/signed
Projects
None yet
Milestone
0.7.1
Development

Successfully merging this pull request may close these issues.

FilterProcessor fails to assemble predicate if condition column is empty
2 participants
@raviks789 @nilmerg